Issue #3431: unusable text entry on "files changed" tab for visitors - pagure

pagure

#3431 unusable text entry on "files changed" tab for visitors

Closed: Fixed 5 years ago Opened 5 years ago by billauger.

steps:

sign out of pagure
open the "files changed" tab of a pull request
click on the "add comment" bubble icon

expected:

nothing should happen as you must be signed in to comment
the "add comment" bubble icon probably should not be presented unless signed in

actual:

an empty text entry area is presented that is in read only mode

pingou commented 5 years ago

The code in git will show you the authentication page if using local auth or a, very unclear, button that redirects you to the authentication provider if using openid.

I'm inclined to think we should just not show the button if not authenticated.

Thanks for the report!

Metadata Update from @pingou:
- Issue tagged with: bug, easyfix

5 years ago

billauger commented 5 years ago

i noticed this on pagure.io

Edited 5 years ago by billauger

Metadata Update from @farhaan:
- Issue assigned to farhaan

5 years ago

farhaan commented 5 years ago

bug replicated I feel I going to hide the button if not authenticated.

pingou commented 5 years ago

Commit 7252179 fixes this issue

Metadata

Assignee

farhaan

Tags

Blocking

None

Depending on

None

Priority

None

Milestone

None

pagure

Source Code

Documentation

#3431 unusable text entry on "files changed" tab for visitors Closed: Fixed 5 years ago Opened 5 years ago by billauger.

Metadata

easyfix bug

#3431 unusable text entry on "files changed" tab for visitors

Closed: Fixed 5 years ago Opened 5 years ago by billauger.