Learn more about these different git repos.
Other Git URLs
Hey, so I've run into an issue while running an instance of Pagure that has CASE_SENSITIVE = True - it doesn't really work as expected. For example, if I create a project "foo", I can't create project "FOO" afterwards, since [1] doesn't respect the value from settings and searches for projects in case-insensitive way.
CASE_SENSITIVE = True
I think the right solution here would be to have _get_project use the value of CASE_SENSITIVE directly from pagure_config instead of accepting it as an argument. Does that make sense? I can send a PR if so.
_get_project
CASE_SENSITIVE
pagure_config
[1] https://pagure.io/pagure/blob/master/f/pagure/lib/__init__.py#_1584
It sounds good, though I'd expect the case-insensitive check to have been performed earlier in the code, are you using a custom script or is this something you're seeing in a "normal" pagure usage?
You're correct that I found this in a custom extension to Pagure that I created, but I can also reproduce it in a freshly checked out unmodified local instance - I created project "asd" and I can't create project "ASD" now, even though CASE_SENSITIVE is set to True.
True
I created project "asd" and I can't create project "ASD" now, even though CASE_SENSITIVE is set to True.
Oh, I wonder if we don't have the correct behavior but the configuration key backward :s
Well the code linked in the original report doesn't respect this setting either way, so I'll figure this out while working on the fix for this.
Thanks
Metadata Update from @pingou: - Issue assigned to bkabrda - Issue tagged with: bug
Commit 1e87ae2 fixes this issue
Login to comment on this ticket.