#3242 Links in commit messages are not active
Closed: Fixed 5 years ago Opened 5 years ago by abitrolly.

At https://pagure.io/pagure/c/7058f65 links in commit message text are not clickable

Explain admin access to four repositoris

Closes https://pagure.io/pagure/issue/3209
Merges https://pagure.io/pagure/pull-request/3210

That is kind of expected as the commit messages are rendered in <pre> tags not as markdown.

Rendering the commit messages as markdown had other issues: https://pagure.io/pagure/issue/3088

Eaten __init__ is not that big UX issue compared to links that can not be easily followed. And there is always patch for people who don't need any UI rendering of raw git data https://pagure.io/pagure/c/7058f65.patch

@lsedlar want to chime in? :)

As I didn't ask for a full markdown, I think we can get to compromise of just making links clickable. I think Chromium tracker doesn't try to render markdown at all but highlights links https://bugs.chromium.org/p/monorail/issues/detail?id=3376&q=&colspec=ID%20Type%20Status%2FClosed%20Priority%20Milestone%2FQueue%20Owner%20Summary&desc=2

Doing some sort of light-weight markdown may be a good middle-ground.

Would you be interested to look into it?

Metadata Update from @pingou:
- Issue tagged with: RFE

5 years ago

I am interested, but.. I have no money to go on, so need to find out some sustainability scheme. Setup https://chaoss.community/participate/ to see how much time I am spending on various open source projects and seek ways to compensate it.

+1 came here to file this.

I agree that the source is plain text and should be preserved in the display, but linking is a minor tweak (from a user perspective). I mean, the terminal does it...

We do use Python Bleach in other places in pagure, bleach's linkify seems a good candidate for solving this maybe.

Metadata Update from @ryanlerch:
- Issue assigned to ryanlerch

5 years ago

Metadata Update from @ryanlerch:
- Issue set to the milestone: 5.2
- Issue tagged with: UI

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4070 Merged 5 years ago