#3190 404 on 'Commits' header on Files tab when viewing a commit
Closed: Fixed 5 years ago Opened 5 years ago by docsavage2k.

A 'Page not found (404)' error is encountered when clicking on the 'Commits' header link after viewing the files of a commit by clicking on a release. The URL being used on the Commits link contains the commit hash, rather than the expected branch name. When viewing Files by branch based routes, it the link functions as expected.

This was seen on the current live version (3.13.2).

Steps to reproduce:
1. Click onto any project
2. Click onto the 'Releases' tab
3. Click onto a release in the list

You should now have the release files listed, and from this point forward while on the Files tab, the 'Commits' URL is invalid, causing the 404.

It looks like this /commits path only takes the branch name, to display a commit, as seen by taking a working route into 'Commits', the URL is the format:
/c/%COMMIT_HASH%?branch=%BRANCH_NAME%
i.e.
/c/4e0b4b6?branch=master

Files needs to use the appropriate URL depending on whether it is showing a commit or branch.


We can definitively improve that :)

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #3258 Merged 5 years ago