#316 RFE: Make ssh protocol more obvious
Closed: Fixed None Opened 5 years ago by till.

Currently pagure uses just

git@pagure.org:pagure.git

as URL for SSH access. This does not make it obvious that SSH is used here. Therefore I propose to use

ssh://git@pagure.org/pagure.git

instead. However supporting this will break the current config file as it only contains

GIT_URL_SSH = 'git@pagure.org'

and this requries a colon to separate the path, but the new full URL syntax requires a slassh.

To make it possible to use both in the future, I suggest to add the first path separator into the config setting, e.g. setting

GIT_URL_SSH = 'ssh://git@pagure.org/'

and if someone wants the old URL, they have to set

GIT_URL_SSH = 'git@pagure.org:'

I can prepare a pull request, if you agree with this.


Currently pagure uses just
git@pagure.org:pagure.git

as URL for SSH access. This does not make it obvious that SSH is used here. Therefore I propose to use
ssh://git@pagure.org/pagure.git

While I have nothing against it, what is the gain of it?

instead. However supporting this will break the current config file as it only contains
GIT_URL_SSH = 'git@pagure.org'

and this requries a colon to separate the path, but the new full URL syntax requires a slassh.
To make it possible to use both in the future, I suggest to add the first path separator into the config setting, e.g. setting
GIT_URL_SSH = 'ssh://git@pagure.org/'

and if someone wants the old URL, they have to set
GIT_URL_SSH = 'git@pagure.org:'

I can prepare a pull request, if you agree with this.

hm, putting the first path separator might require using something like the [1:] in the template, nice the nicest but doable.

I don't see much gain but I don't see much harm either so PR welcome :)

Currently pagure uses just
git@pagure.org:pagure.git
as URL for SSH access. This does not make it obvious that SSH is used here. Therefore I propose to use
ssh://git@pagure.org/pagure.git

While I have nothing against it, what is the gain of it?

It makes it clear that SSH is used, I remember that it confused people maybe in the releng irc that there was not protocol, so they assumed it is the native git protocol.

hm, putting the first path separator might require using something like the [1:] in the template, nice the nicest but doable.
I don't see much gain but I don't see much harm either so PR welcome :)

The path separator in the template can just be removed, see the pull request #317 - it will require the config file in Fedora's ansble to be updated.

Login to comment on this ticket.

Metadata