#3119 Generic webhooks are confusing and (possibly) don't work
Closed: Fixed 6 years ago Opened 6 years ago by jcline.

Attempting to set up a generic webhook for a Pagure project is confusing and, apparently, they don't work.

The documentation is not clear on where to set up your webhooks beyond the setting page, and the field (apparently "Activate Web-hooks : " in the project options?) doesn't look like I'd expect as a user. How does one enter multiple webhooks? The form gives no indication. What events triggers the webhook? It's not clear.

Thus, I have no idea if they work or not, but my expectation is that a push to the default branch would be an event that triggers the web-hook. When I push to the default branch of a repository, the webhook does not fire. Pressing the "test web-hook" button does cause the webhook to fire, so I'm at least certain it's configured.


The current implementation is that web-hook notifications are sent everytime a fedmsg message is sent, which means if you want web-hooks notifications on commits, you need to turn on the fedmsg hook.

Since this isn't quite the desired behavior, it has been adjusted in git (for the upcoming 4.0 release) where it will trigger notifications on every action in the UI as well as per commit if activated.

As for adding multiple web-hooks the code says that there should be one target URL per line which isn't ideal with the current form. I'll see to change that.

Metadata Update from @pingou:
- Issue assigned to pingou

6 years ago

Commit 28ae476 relates to this ticket

Login to comment on this ticket.

Metadata