Learn more about these different git repos.
Other Git URLs
Order individual line comments in a pull request by the order of the line, not by the time of the comment
In a pull request, Pagure orders line comments by the time they are received. If a reviewer adds comments later, all the line comments will not appear sequentially. When reviewing a PR, it is more difficult to review feedback if a reviewer added more comments after an initial pass.
An example of this is in fedora-commops#146 (screenshot of one example below).
<img alt="Screenshot-2018-3-29_PR146_Update_CommOps_overview_for_2018_-_fedora-commops_-_Pagure.png" src="/pagure/issue/raw/17b526de9d78f92df70a974e42e0a813737a749354e6ab856074fa8f40f10756-Screenshot-2018-3-29_PR146_Update_CommOps_overview_for_2018_-_fedora-commops_-_Pagure.png" />
All line comments should be sorted sequentially in order of line, by all reviewers. This makes code easier to review when going through a PR with many comments, especially if comments were added in a different order than by line number. Organizing comments by lines make them easier to review and more intuitive for me as a reviewer.
Sort line comments by line, not by time of comment, to improve ease of review and implementing feedback from comments
I'm not entirely sure this is doable based on the current implementation of comments.
Metadata Update from @pingou:
- Issue tagged with: RFE, wishful
Metadata Update from @ryanlerch:
- Issue marked as blocking: #3823
to comment on this ticket.