#3090 Opening a PR on an empty repo may lead to an error
Closed: Fixed 4 years ago Opened 4 years ago by abompard.

See PR #3089 for the details. Basically, if the pagure.lib.tasks.sync_pull_ref() task runs fast enough, it will create the refs/pull references in the git repo before the call to diff_pull_request() in the PR view. This function will call get_diff_info(), where the .is_empty condition there returns False because refs/pull/ isn't empty, but there is still no target master branch. As a result, there will be a flash error message with "Branch master could not be found in the target repo".
We should make that condition smarter.


Metadata Update from @pingou:
- Issue tagged with: bug

4 years ago

Metadata Update from @pingou:
- Issue assigned to pingou

4 years ago

Fixed in ef234eb7f5ebf06f198cab7f7c9d6399dd48d282 which is part of https://pagure.io/pagure/pull-request/3054

Login to comment on this ticket.

Metadata