#2986 Automatic links to issues and PRs sometimes not working
Opened 6 years ago by adamwill. Modified a year ago

When you type an issue or PR number - like #2973 , say - into a Pagure issue or PR description, it's supposed to automatically become a link to that issue or PR. But right now, that's not working. Not in any project I've tested. This issue won't link to issue #2964 or #2607 or pull request #1734 . They'll just all be plain text.

I think related to this, if you start a line with an issue or PR number, intending to link to it, it turns into a heading, like this:

#2605 is also an issue


Huh - so the links did appear when I created the issue in this case. But the javascript auto-complete drop-down-y thing didn't appear, and the links didn't appear in the preview. And the 'heading' problem is real.

So, update: I tested creating a new issue in fedfind. Again the auto-complete box thing didn't appear when I'm typing the number, and the preview doesn't show the link, but the link does appear when I actually create the issue.

However, in this fedora-qa issue it seems totally broken. I just created a new comment in that issue trying to link to issue #541 and again it didn't work. (Weirdly, the auto-complete box thing just appeared while I was typing that number. What? I'm so confused.)

https://pagure.io/fedora-qa/os-autoinst-distri-fedora/issue/68 - I got the 'no link in preview, no auto-complete , but links did appear in created issue' behaviour.

Filed #2987 for the section heading issue.

If I start typing #298... here I'm seeing the drop down menu with the different issue :(

Ok, I came here to comment I couldn't reproduce it and that I was tempted to close this, and then "tada" I could reproduce it.

Basically the issue seems to be in the time it takes to query all PR and issues from the API. If you wait long enough the request returns and it works again.
We may want to see if we can optimize some of this.

Which issue? The javascript one (auto-complete box sometimes not appearing) or the links, or both?

I think I noticed the same thing, though - for e.g. if I go back to https://pagure.io/fedora-qa/issue/540#comment-494708 , which definitely didn't show as a link when I posted https://pagure.io/pagure/issue/2986#comment-494709 , now it does show as a link...

I was speaking about the auto-complete box not appearing

Metadata Update from @wombelix:
- Issue set to the milestone: 6.0

a year ago

Login to comment on this ticket.

Metadata