Learn more about these different git repos.
Other Git URLs
Sometimes, you submit a pull-request.
And then you realized that you shouldn't have, for whatever reason.
This happened to me with https://pagure.io/fedpkg/pull-request/1 : I opened it, to get the code merged then I realized that as much as this code should be merged, it shouldn't be merged right now, and waiting a bit would make the migration easier * and in fact, bundling it with another change would make the migration even easier
So in this case, I wanted to close this pull-request completely, until I was ready to open a new one, with those 2 changes bundled.
Closing the pull-request was better than leaving it hanging, because it avoids the maintainer merging the changes by mistake.
I had to ask Pierre-Yves to close the pull-request for me, but as the submitter, it would have been much better if I had been able to do that myself. :smile:
Hi @dhrish20,
How is this ticket going? Do you need help with anything?
@pingou
I need help on this. How do i proceed?
@dhrish20,
Do you have a local instance of pagure running ?
@pingou yes i do have
Sorry wrong issue, you need to:
Adjust the controller to let the user that opened the PR close it, this is at: https://pagure.io/pagure/blob/master/f/pagure/ui/fork.py#_541
Adjust the template to show the close button to the user that created the PR, this is at: https://pagure.io/pagure/blob/master/f/pagure/templates/pull_request.html#_31
Fixed https://pagure.io/pagure/pull-request/410
Login to comment on this ticket.