#2612 Commit hash are not displayed as links in namespaces
Closed: Fixed 6 years ago Opened 6 years ago by lslebodn.

Repo contains hash d713c1f979ba3e046a6dd53f5262ae0cdbe53bc4 and ticket contains following text:

master:

* d713c1f979ba3e046a6dd53f5262ae0cdbe53bc4

Hash is properly displayed as a link to commit message only in base git repo
e.g.
https://stg.pagure.io/ding-libs/issue/3167

It does not work in namespaces:
https://stg.pagure.io/sssd/ding-libs/issue/1


Metadata Update from @lslebodn:
- Issue tagged with: IDM

6 years ago

I suspect this got already fixed in https://pagure.io/pagure/pull-request/2589

Though it would need to be confirmed :)

Metadata Update from @pingou:
- Issue tagged with: bug

6 years ago

I suspect this got already fixed in https://pagure.io/pagure/pull-request/2589
Though it would need to be confirmed :)

You can deploy that to staging instance and then I can confirm :-)

@pingou then let me know when you deploy "beta" with fix from #2589 to staging instance.

@pingou
ATM, pagure.io has version 3.7.1 and stg.pagure.io has 3.8 but I still cannot see hash as a link in namespaced project https://stg.pagure.io/sssd/ding-libs/issue/1

Am I just impatient? :-)

No it should work :(

then bug is not fixed :-)

Metadata Update from @pingou:
- Issue assigned to pingou

6 years ago

Commit 17a1bf6 fixes this issue

And I assume it is is not part of 3.8 release because it still does not work in production https://pagure.io/SSSD/sssd/issue/3531#comment-470223 :-)

Looking forward to a new version and for unit test to prevent regressions :-)

Login to comment on this ticket.

Metadata