#2526 External images can't be in-lined in issues and it's not clear why
Closed: Fixed 6 years ago Opened 6 years ago by kparal.

The markdown syntax says this can be used to include in-line images:

![Alt text](/path/to/img.jpg)

However, it doesn't work on pagure. It also says <img> tag can be used, but that doesn't work either.


test image

As you can see, it doesn't work for me. I used:

![test image](https://68.media.tumblr.com/avatar_25efafdbc2ba_128.png)

and it created:

<p><img alt="test image"></p>

What code have you used?

That does not work in purpose, we do not want to link to images uploaded anywhere on the web.

Good to know. Why?

Also, it's unobvious. Perhaps the Markdown Syntax button under new comment box could lead to a page on pagure documenting which markdown commands are supported and which are not? Alternatively, an error can be displayed when somebody tries to use that syntax, possibly even inline (instead of showing the image, show "linking to external images is not allowed" text).

Good to know. Why?

There was security issues at one point about using the img tag to link to something that wasn't an image (like a js blob or so) and since we're serving the content via the same domain it could be problematic.

Also, it's unobvious. Perhaps the Markdown Syntax button under new comment box could lead to a page on pagure documenting which markdown commands are supported and which are not? Alternatively, an error can be displayed when somebody tries to use that syntax, possibly even inline (instead of showing the image, show "linking to external images is not allowed" text).

Those are good ideas :)

Metadata Update from @pingou:
- Issue tagged with: RFE

6 years ago

For a start I went with linking to pagure's own markdown documentation and adding a warning there about remote images.

Metadata Update from @pingou:
- Issue assigned to pingou

6 years ago

Login to comment on this ticket.

Metadata
Attachments 2
Attached 6 years ago View Comment