#2430 [RFE] Offer changing commit message before merging
Opened 6 years ago by mzidek. Modified a year ago

It would be nice if the "merge" button (to merge PR) was accompanied with a checkbox "Amend commit messages before merging" (or something similar).

After clicking on "merge" with the checkbox checked, it would open dialog boxes (one for each commit in the PR) with commit messages and allow to change them here before proceeding with the merge.

This way it would be easier to add custom tags such as "Reviewed-by" to the commit messages or fix a simple typo without the need to exit the webui and do this in git's cli.

The UI change mentioned is just an example of how it could be done. Of course it can be done in many different ways.


Metadata Update from @pingou:
- Issue tagged with: RFE

6 years ago

In general and until now I have refused that pagure touches the commit messages, so I am not sure I am inclined to change this.

I am keeping this open for now though.

Metadata Update from @pingou:
- Issue tagged with: wishful

6 years ago

Hi @pingou !

I am curious, why you do not want pagure to touch the commit messages? Is there a security reason behind it? Would it help if this feature was optional and enabled in the project settings?

why you do not want pagure to touch the commit messages?

I am not sure I have a very reasonable explanation for this, it was more a matter of principle, don't really want pagure to change the content created by the users.
But this lack of actual argument is also what makes me keep this ticket open now :)

Is there a security reason behind it?

There could be, but not that I can think of right now :)

Ok, thanks for the answer.

Metadata Update from @wombelix:
- Issue set to the milestone: 6.0

a year ago

Login to comment on this ticket.

Metadata