#2312 Creating a PR when pagure-ci is not enabled results in 500
Closed: Fixed 6 years ago Opened 6 years ago by tflink.

If I'm using a pagure instance without ci enabled (for example https://upstreamfirst.fedorainfracloud.org/), there is a 500 whenever a PR is created.

The TB looks like:

[Fri May 26 13:08:44.745461 2017] [:error] [pid 28750] 2017-05-26 13:08:44,640 [ERROR] pagure: Exception on /fork/tflink/testing-project/diff/master..master [POST]
[Fri May 26 13:08:44.745481 2017] [:error] [pid 28750] Traceback (most recent call last):
[Fri May 26 13:08:44.745483 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
[Fri May 26 13:08:44.745485 2017] [:error] [pid 28750]     response = self.full_dispatch_request()
[Fri May 26 13:08:44.745487 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
[Fri May 26 13:08:44.745489 2017] [:error] [pid 28750]     rv = self.handle_user_exception(e)
[Fri May 26 13:08:44.745490 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
[Fri May 26 13:08:44.745492 2017] [:error] [pid 28750]     reraise(exc_type, exc_value, tb)
[Fri May 26 13:08:44.745494 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
[Fri May 26 13:08:44.745500 2017] [:error] [pid 28750]     rv = self.dispatch_request()
[Fri May 26 13:08:44.745502 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
[Fri May 26 13:08:44.745504 2017] [:error] [pid 28750]     return self.view_functions[rule.endpoint](**req.view_args)
[Fri May 26 13:08:44.745506 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/pagure/ui/fork.py", line 990, in new_request_pull
[Fri May 26 13:08:44.745507 2017] [:error] [pid 28750]     commit_stop=commit_stop,
[Fri May 26 13:08:44.745509 2017] [:error] [pid 28750]   File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1521, in new_pull_request
[Fri May 26 13:08:44.745511 2017] [:error] [pid 28750]     if REDIS and request.project.ci_hook and PAGURE_CI \\
[Fri May 26 13:08:44.745512 2017] [:error] [pid 28750] AttributeError: 'Project' object has no attribute 'ci_hook'

Fix the PR creation code so that it doesn't blow up if no CI is configured


Login to comment on this ticket.

Metadata