#2245 Diff says "empty file added" for non-empty binary files
Closed: Fixed 2 years ago Opened 3 years ago by mikem.

This PR adds a few binary files used for unit tests. In the diff, Pagure says they are empty:

https://pagure.io/koji/pull-request/384#request_diff


Screenshot_from_2017-04-20_10-44-24.png

Seen this too. A screenshot is attached. It is an image file, and the PR in question is: https://pagure.io/fedora-docs/quick-docs/pull-request/73
pagure-image-empty-file-added.png

Still happening in 5.0.

Metadata Update from @ryanlerch:
- Issue set to the milestone: 5.2

2 years ago

Metadata Update from @ryanlerch:
- Issue assigned to ryanlerch

2 years ago

Ok, I've spent some time in this and it looks like pygit2 doesn't really give us anyway to tell apart empty files from binary files.

So I suggest this "fix":

-          <div class="text-muted text-xs-center">empty file added</div>
+          <div class="text-muted text-xs-center">empty or binary file added</div>

I'll submit a PR for this, @ryanlerch would you like to review it?

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #4119 Merged 2 years ago