Learn more about these different git repos.
Other Git URLs
Current git diff of pull requests is suboptimal. It doesn't show proper lines which changed and doesn't provide info about classes, functions where chunk is.
I attached file with POC where by using pygit2 I was able to create such diff and it can be transformed from CLI to HTML (I just don't know how and where to put such function)
<img alt="pygit-diff.py" src="/pagure/issue/raw/c6dbb1acec8c2bd8c01b31a1d56ee78b27600c4f9f54ec01bb6a39dbc277681b-pygit-diff.py" />
Does it work with pygit2 0.21 ? It's the minimal version we support since it is the version present in epel7
No it doesn't work with pygit 0.21, there are missing a lot of things :-(
Why can't we just get an updated version of pygit into EPEL? As a parallel installable package if needed. This doesn't even take a package review.
@tibbs I think there are already BZ tickets
https://bugzilla.redhat.com/show_bug.cgi?id=1426035 https://bugzilla.redhat.com/show_bug.cgi?id=1434892
Metadata Update from @pingou: - Issue tagged with: RFE
Metadata Update from @lslebodn: - Issue tagged with: IDM
https://pagure.io/pagure/pull-request/3051 is bumping the minimal version to 0.22.1, maybe we could bump it to 0.24.2 (which is what we currently have in epel7)
@mbasti do you remember from which version this code should work?
I think it should work with 0.24.2, I had a POC on a branch[0] for that too. I am pretty sure it is broken but it could be a starting point.
[0] - https://pagure.io/fork/cverna/pagure/diff/master..add_lineno_to_diff
@cverna if that's still a thing in the latest release (5.13.3), would you mind to create a PR to further discuss and work on it? I don't see a reason at this point to leave the issue open after 4 years without updates.
Metadata Update from @wombelix: - Issue close_status updated to: Insufficient data - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.