#2085 Support non-HTTP/HTTPS links (or error out)
Closed: Fixed 7 years ago Opened 7 years ago by rharwood.

I tried to add a link to an IRC channel to a markdown document, and Pagure instead gave me a link to the current page. It would be nice if irc:// and ircs:// were supported protocols, or (probably better yet) there isn't a checked protocol list. Also dumping the current page link seems potentially problematic.


Metadata Update from @lslebodn:
- Issue tagged with: IDM

7 years ago

But there isn't such a list (checked protocols) at least on pagure, I wonder if this is a bug in python-markdown in which case it should be reported there.

Also dumping the current page link seems potentially problematic.

I don't understand what you mean here.

Also dumping the current page link seems potentially problematic.

I don't understand what you mean here.

The behavior I observed was that it replaced the irc:// link with a link to the current page. Without knowing why it does this, that seems potentially dangerous, but it's hard to say.

Ok, turned out there is a list of supported protocols, I've added irc and ircs to it :)

Metadata Update from @pingou:
- Issue assigned to pingou

7 years ago

So after spending most of my afternoon on this I finally have a PR, partly working: https://pagure.io/pagure/pull-request/2109

tldr; irc:// links will work but not ircs://

Login to comment on this ticket.

Metadata