pagure

#2065 Comment "edit" action sends wrong email link
Closed: Fixed Opened by stlaz.

Closed: Fixed
Reopen Issue

Usually when you do some action at an issue, you are sent an email pointing to the issue/comment at the issue. When editing a comment, you are sent an email offering a link to https://pagure.io instead of a link to the actual edited comment.

Steps to reproduce:
1. Open an issue
2. Post a comment at the issue
3. Edit the comment
4. Get a mail

Expected:
Got a link to the edited comment

Got:
Got a link to https://pagure.io

This probably has to do something with the strange Pagure behavior where editing a comment points you to a new page instead of being able to edit the comment at the page the comment originally appeared.

edit: was this behavior fixed recently?

Could you check where this email is coming from? Because pagure doesn't send email when a comment is edited so I doubt it's a pagure issue :)

:thumbsup: Good, then! It's coming from notifications@fedoraproject.org, perhaps someone from our team set it up, then, I should probably consult with them. Sorry.

The issue is actually in fedmsg_meta_fedora_infrastructure then, it's a known but unresolve one.

The problem was that the original messages sent upon edit did not include enough information to build the link properly.
This is now fixed iirc, so we should improve fedmsg_meta for this.

Metadata Update from @lslebodn:
- Issue tagged with: IDM

Fixed in https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/467

Metadata Update from @pingou:
- Issue assigned to pingou

And merged upstream :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
Metadata

IDM

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.