Issue #2013: Internal server error when opening PR - pagure

pagure

#2013 Internal server error when opening PR

Closed: Fixed 7 years ago Opened 7 years ago by lsedlar.

I have opened two pull requests on https://pagure.io/releng/python-multilib
Both times after submitting the form I got an Internal server error (without details what went wrong).

The pull request itself was created though. I have not seen any fedmsg announcing it yet, so either it was not sent or it's still backlogged somewhere.

pingou commented 7 years ago

So this is due to a bug that's going on for a few days but that I have not been able to track back, basically the error is:

  File "/usr/lib/python2.7/site-packages/pagure/ui/fork.py", line 292, in request_pull
    requestfolder=APP.config['REQUESTS_FOLDER'])
  File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1407, in diff_pull_request
    notify=False, notification=True
  File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1126, in add_pull_request_comment
    and request.project.ci_hook and PAGURE_CI:
AttributeError: 'Project' object has no attribute 'ci_hook'

  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib/python2.7/site-packages/pagure/ui/fork.py", line 1073, in new_request_pull
    requestfolder=APP.config['REQUESTS_FOLDER'],
  File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1557, in new_pull_request
    if REDIS and request.project.ci_hook and PAGURE_CI:
AttributeError: 'Project' object has no attribute 'ci_hook'

But project do have a ci_hook attribute, it's a backref coming from the PagureCiTable defined in the hooks.

This has been working since we introduced pagure-ci and suddenly doesn't, with the added bonus that I haven't managed so far to reproduce it locally, fun right?

lsedlar commented 7 years ago

The fedmsgs have just been sent, so this has no effect other then the message is shown as far as I can tell.

cqi commented 7 years ago

I found internal server error when refresh PR page right away just after updating a PR with git push --force. Is this a relative issue caused by same or similar problem? If not, I can file another issue for it.

farhaan commented 7 years ago

I found internal server error when refresh PR page right away just after updating a PR with git push --force. Is this a relative issue caused by same or similar problem? If not, I can file another issue for it.

I guess its same issue

pingou commented 7 years ago

@cqi, logs are clear, same root cause:

  File "/usr/lib/python2.7/site-packages/pagure/ui/fork.py", line 292, in request_pull
    requestfolder=APP.config['REQUESTS_FOLDER'])
  File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1407, in diff_pull_request
    notify=False, notification=True
  File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1126, in add_pull_request_comment
    and request.project.ci_hook and PAGURE_CI:
AttributeError: 'Project' object has no attribute 'ci_hook'

pingou commented 7 years ago

Fixed in: https://pagure.io/pagure/pull-request/2023 (hotfixed in prod as well)

Metadata Update from @pingou:
- Issue assigned to pingou

7 years ago

Metadata Update from @pingou:
- Issue tagged with: bug

7 years ago

pingou commented 7 years ago

Commit d9a2399 fixes this issue