#1753 Give links to the lines in the proposed file while giving out diff in a PR's "Files Changed" tab.
Closed: Fixed 7 years ago Opened 7 years ago by vivekanand1101.

First of all, i don't know how this can be implemented as of now, leave alone how hard it is.

When we see the diff while viewing the changes in a PR - the "Files changed" tab, we see a lot of '+' and '-'s. I was thinking if we can add links to the files in the PR's request.branch somewhere around '+' s . This will make life easier while reviewing. Sometimes, i tend to go to that file using the file link given at the top and then use Ctrl-f.


Here's a quick proposal and some Inspect-foo.

Screenshot_from_2017-01-13_02-32-30.png

Imagine my pointer is on the share-like symbol at the end of line 1. If you clicked it, it would open the file in a new tab and scroll to the relevant line number (we simply add #_xx to the URL of the file where xx is the line number). We can get this line number from the diff info itself. In this example, we would get line number as 481 from @@ -481,24 +481,24 @@.

Does that make sense at all?

@vivekanand1101 I am no getting you properly can you be a little more elaborate :)

Since, the PR is merged, we can close this issue.

Metadata Update from @vivekanand1101:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

7 years ago

Login to comment on this ticket.

Metadata
Attachments 1