pagure

#1752 Issue activity is shown as regular comment
Closed: Fixed Opened by cep.

Closed: Fixed
Reopen Issue

When you are on an issue page, new comments and activities on the issue are automatically displayed. Such activities are shown as regular comments, but are shown properly when the page is reloaded.

Steps to reproduce:
- Open an issue page.
- Click 'Edit Metadata' and update the status of the issue as closed.
- See new comment added automatically.

Screenshot_from_2017-01-13_00-55-54.png

If you can't reproduce the issue locally, use https://stg.pagure.io.

Expected:

Screenshot_from_2017-01-13_00-56-21.png

I think it had something to do with the SSE ?

I tried this... just now
Screenshot_from_2017-01-13_01-00-14.png

I can confirm that it wasn't an one-off issue.

I noticed this on pagure.io and tested it on stg.pagure.io, where I can still reproduce it. Inspecting the comment showed that it was wrapped in a <div id="comment-*"> div like regular comments.

That is true, notifications are first shown as regular comments and it's updated to notifs on reload.

That is true, notifications are first shown as regular comments and it's updated to notifs on reload.

Something i wouldn't be able to notice since my browser can't connect to the sse server :/ . Thanks to my college's network committee.

That is true, notifications are first shown as regular comments and it's updated to notifs on reload.

If you mean that this is intended behaviour, I propose we change it to display notifications in notifs style itself. Notifications that appear as regular comments and then change style on reload is odd, and a bit confusing imho.

Something i wouldn't be able to notice since my browser can't connect to the sse server :/ . Thanks to my college's network committee.

College network committees do have a knack for doing things like banning Github and StackOverflow :joy:

If you mean that this is intended behaviour, I propose we change it to display notifications in notifs style itself.

Not sure if it is the intended behavior but it certainly is the current one :)

:thumbsup: to change it :)

I believe this has been fixed now, going to give it a try on this very ticket :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed

Damn it, the page reloaded so I couldn't test it, but I still think it has been fixed

Metadata Update from @pingou:
- Issue assigned to pingou

Confirmed it works :)
Metadata

bug

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.