There is already https://pagure.io/pagure/issue/1621 asking for the list of subscriber which I think is a good idea, but I do not think that list should be made editable, it is up to the individual person to subscribe/unsubscribe to an issue imho.

I was looking for existing issues - sorry I missed 1621. Well I already have a patch showing all the subscribers, and it is almost working for adding and removing users. I was thinking it would be nice for an admin's to have this ability to add a user to a issue without them having to do it themselves. Anyway, if you really don't want it editable then I already have a patch ready to go.

Let's do that in two steps, display first, edit later as I am not entirely sure yet what to do with it.

For reference, the ticket I meant to linked to is https://pagure.io/pagure/issue/1093 to 1621 (which you could not have found since it was created after this one)

Patch to list subscribers in Issues

Hmmm looking at #1093, this patch does not update the pull request page. Although the functionality is present to query pull-request watchers.

I didn't add it to the pull-requests page because I did not see a subscribe button for pull-requests. Did I miss something?

No it's indeed absent on the PR page, the logic is there but it's not implemented as people where apparently less interested.

However the watchers does not contain everything, owners or group members aren't listed in there unless they explicitly opt-out (since they are opted-in by default)

No it's indeed absent on the PR page, the logic is there but it's not implemented as people where apparently less interested.
However the watchers does not contain everything, owners or group members aren't listed in there unless they explicitly opt-out (since they are opted-in by default)

I'm working on a new patch now for adding subscribers to pull-requests (and always add the owner to the subscribers), but I'm not sure how to get "group members". Can you point me in the right direction?

Well the current subscribe/unsubscribe does not work with groups, so I'm going to leave that out for now as I'm not really sure how this applies. Perhaps this can be done in a separate step.

Updated patch for PR page, and adding owner to the subscriber lists.

I'm not sure how to get "group members". Can you point me in the right direction?

Did you see how pagure.lib.is_watching() is doing it?

Corresponding PR: https://pagure.io/pagure/pull-request/1630 with unit-tests and all :)