Submitting a patch for this issue. Please review, thanks!

This is looking good but a few things:

• the type is link while you split on commas, so it supports multiple links,
  maybe we could rename it to links instead? Or just drop having multiple
  links in that field which in a way sounds more appealing to me (also cf below
  about validation)
• I had to make few adjustments to get it working:

diff --git a/ pagure/templates/issue.html b/ pagure/templates/issue.html
index a5a0ea7..639ac7a 100644
--- a/ pagure/templates/issue.html      
+++ b/ pagure/templates/issue.html      
@@ -324,13 +324,15 @@
             <label><strong>{{ field.name }}</strong></label>
             <div id="{{ field.name }}_plain">
               <p>
-                {% if field.key_type == 'link' %}
-                  {% for link in knowns_keys[field.name].value.split(',') %}
-                    <a target="_blank" href="{{ link }}">{{ link }}</a>
-                    <br>
-                  {% endfor %}
-                {% else %}
-                  {{ knowns_keys[field.name].value if field.name in knowns_keys }}
+                {%  if field.name in knowns_keys %}
+                  {% if field.key_type == 'link' %}
+                    {% for link in knowns_keys[field.name].value.split(',') %}
+                      <a target="_blank" rel="noopener noreferrer" href="{{ link }}">{{ link }}</a>
+                      <br>
+                    {% endfor %}
+                  {% else %}
+                    {{ knowns_keys[field.name].value }}
+                  {% endif %}
                 {% endif %}
               </p>
             </div>
diff --git a/ pagure/templates/settings.html b/ pagure/templates/settings.html
index f5cb450..c9bc445 100644
--- a/ pagure/templates/settings.html   
+++ b/ pagure/templates/settings.html   
@@ -951,6 +951,7 @@ $('#new_custom_field').click(function(e) {
            <select name="custom_keys_type" class="form-control"> \
             <option value="text">text</option> \
             <option value="boolean">boolean</option> \
+            <option value="link">link</option> \
           </select> \
         </div> \
       </div>'

Mind adding this to your commits? Or do you prefer me putting it on the top of
it?

I was also wondering if there should be some validation in this case, maybe
something using validators.URL() from wtforms? I do not know if that
validator would work well for our current input since we allow multiples URLs to
be passed (one argument in favor of allowing just one URL imho).

We will also need to adjust the issue_ev.js once we're merged the PR allowing to
live refresh the values of the custom fields based on notifications from the SSE
server.

This is looking good but a few things:

the type is link while you split on commas, so it supports multiple links,
maybe we could rename it to links instead? Or just drop having multiple
links in that field which in a way sounds more appealing to me (also cf below
about validation)

I'll change it to links. We need to "link" multiple bugzilla's to a single issue. So it needs to be multi-valued. More on this below.

I had to make few adjustments to get it working:

Odd, perhaps the code base changed since I attached my patch? It was fully functional in my dev env a few days ago.

diff --git a/ pagure/templates/issue.html b/ pagure/templates/issue.html
index a5a0ea7..639ac7a 100644
--- a/ pagure/templates/issue.html
+++ b/ pagure/templates/issue.html
@@ -324,13 +324,15 @@
<label>{{ field.name }}</label>

- {% if field.key_type == 'link' %}
- {% for link in knowns_keys[field.name].value.split(',') %}
- {{ link }}
-

- {% endfor %}
- {% else %}
- {{ knowns_keys[field.name].value if field.name in knowns_keys }}
+ {% if field.name in knowns_keys %}
+ {% if field.key_type == 'link' %}
+ {% for link in knowns_keys[field.name].value.split(',') %}
+ {{ link }}
+

+ {% endfor %}
+ {% else %}
+ {{ knowns_keys[field.name].value }}
+ {% endif %}
{% endif %}

diff --git a/ pagure/templates/settings.html b/ pagure/templates/settings.html
index f5cb450..c9bc445 100644
--- a/ pagure/templates/settings.html
+++ b/ pagure/templates/settings.html
@@ -951,6 +951,7 @@ $('#new_custom_field').click(function(e) {
<select name="custom_keys_type" class="form-control"> \
<option value="text">text</option> \
<option value="boolean">boolean</option> \
+ <option value="link">link</option> \
</select> \

We could investigate if we can call the validator in a loop, or maybe just check its sources to see if we can re-implement it locally if needed.

Added a URL validator, and applied the suggested changes. Please review this patch.

Thanks,
Mark

I wonder if we couldn't just use a simplified version of https://github.com/kvesteri/validators/blob/master/validators/url.py instead of adding a new dependency. Or maybe just re-use the validator from wtforms since we already depend on that one.

What do you think?

New patch attached using kvesteri's re pattern

Corresponding PR: https://pagure.io/pagure/pull-request/1612

Commit 1a66d85 fixes this issue