pagure

#1527 Emails for namespaced projects don't include the namespace
Closed: Fixed Opened by puiterwijk.

Closed: Fixed
Reopen Issue

When a notification email is sent for a namespaced project, the namespace does not get picked up in the email. This means that the links generated become invalid since they're pagure.io/project instead of pagure.io/namespace/project.

In specific, I received this email from https://pagure.io/modularity/local-dev-env

Return-Path: pagure@pagure.io
Received: from zmta04.collab.prod.int.phx2.redhat.com (LHLO
 zmta04.collab.prod.int.phx2.redhat.com) (10.5.81.11) by
 zmail17.collab.prod.int.phx2.redhat.com with LMTP; Wed, 9 Nov 2016 06:33:11
 -0500 (EST)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
    by zmta04.collab.prod.int.phx2.redhat.com (Postfix) with ESMTP id 73413DA131
    for <sgallagh@mail.corp.redhat.com>; Wed,  9 Nov 2016 06:33:11 -0500 (EST)
Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27])
    by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA9BXB6g021538
    (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO)
    for <sgallagh@redhat.com>; Wed, 9 Nov 2016 06:33:11 -0500
Received: from bastion.fedoraproject.org (bastion01.phx2.fedoraproject.org [10.5.126.12])
    (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
    (No client certificate requested)
    by mx1.redhat.com (Postfix) with ESMTPS id B3C75804EC
    for <sgallagh@redhat.com>; Wed,  9 Nov 2016 11:33:10 +0000 (UTC)
Received: by bastion01.phx2.fedoraproject.org (Postfix)
    id E4AEB6093922; Wed,  9 Nov 2016 11:33:09 +0000 (UTC)
Delivered-To: sgallagh@fedoraproject.org
Received: from pagure01.fedoraproject.org (pagure01.vpn.fedoraproject.org [192.168.100.8])
    by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id CC9F16092717
    for <sgallagh@fedoraproject.org>; Wed,  9 Nov 2016 11:33:09 +0000 (UTC)
Received: from pagure01.fedoraproject.org (localhost [IPv6:::1])
    by pagure01.fedoraproject.org (Postfix) with ESMTP id 304D420BC11D
    for <sgallagh@fedoraproject.org>; Wed,  9 Nov 2016 11:33:09 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [local-dev-env] PR #2 `Update README.md`
From: Petr Hracek <pagure@pagure.io>
mail-id: local-dev-env-pull-request-51ce7e6986454eb8a35a141730807088@pagure
Message-Id: <local-dev-env-pull-request-51ce7e6986454eb8a35a141730807088@pagure>
X-pagure: https://pagure.io/
X-pagure-project: local-dev-env
To: sgallagh@fedoraproject.org
Reply-To: reply+ea1938d0f43d31c978f06e160988d780e966d19cce2faa0a20aaac9415d6109984c73fc022c5d83bba6b345a59b116725ae94b3d45e893b4dbdd298b3cc7f4c6@pagure.io
Mail-Followup-To: reply+ea1938d0f43d31c978f06e160988d780e966d19cce2faa0a20aaac9415d6109984c73fc022c5d83bba6b345a59b116725ae94b3d45e893b4dbdd298b3cc7f4c6@pagure.io
Date: Wed,  9 Nov 2016 11:33:09 +0000 (UTC)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 09 Nov 2016 11:33:10 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 09 Nov 2016 11:33:10 +0000 (UTC) for IP:'10.5.126.12' DOMAIN:'bastion01.phx2.fedoraproject.org' HELO:'bastion.fedoraproject.org' FROM:'pagure@pagure.io' RCPT:''
X-RedHat-Spam-Score: -0.2  (ALL_TRUSTED,BAYES_50) 10.5.126.12 bastion01.phx2.fedoraproject.org 10.5.126.12 bastion01.phx2.fedoraproject.org <pagure@pagure.io>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Scanned-By: MIMEDefang 2.78 on 10.5.110.27
CnBocmFjZWsgb3BlbmVkIGEgbmV3IHB1bGwtcmVxdWVzdCBhZ2FpbnN0IHRoZSBwcm9qZWN0OiBg
bG9jYWwtZGV2LWVudmAgdGhhdCB5b3UgYXJlIGZvbGxvd2luZzoKYGAKVXBkYXRlIFJFQURNRS5t
ZApgYAoKVG8gcmVwbHksIHZpc2l0IHRoZSBsaW5rIGJlbG93IG9yIGp1c3QgcmVwbHkgdG8gdGhp
cyBlbWFpbApodHRwczovL3BhZ3VyZS5pby9sb2NhbC1kZXYtZW52L3B1bGwtcmVxdWVzdC8yCg==

I just noticed this same thing. Additionally, it would also be nice to have the full namespace show up in the email subject line as well (e.g. [ambassadors-na/tasks] instead of [tasks]).

I've a fix ready for the email title

CC @kparal @jsedlak

Fixed by @adamwill in the impressive PR https://pagure.io/pagure/pull-request/1538

@pingou changed the status to Closed

I confirm email notifications are fixed but I can still see fedmsg irc notifications not showing council project name.

That's a bug in fedmsg_meta_fedora_infrastructure which it looks like has not been fixed yet.

Fixed proposed at: https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/409
Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.