#1516 Brainstorming about use of pagure for package reviews
Closed: Won't Fix a year ago by wombelix. Opened 7 years ago by tibbs.

Just some random thoughts about whether pagure could be leveraged for handling package reviews. Note that I haven't looked at the current status of Fresque

  • We'd need a namespace for package reviews, or a separate pagure instance like we'd have for dist-git.

  • Better landing pages to order and sort existing package reviews by various criteria, so we wouldn't need the review tracker page.

  • Some concept of flags on a repository or repository metadata to indicate "sponsor needed" or "approved". Need rights on this metadata, too so only packagers can approve a package. We don't need assignment, though; it should be possible for any packager to approve any in-review package at any time. The idea is to foster quick bits of review work instead of putting people on the hook for doing a review. A packager can always subscribe/follow/watch a particular repository if they want to keep up with it.

  • How to handle abandoned reviews, since a repository would have an owner in a way a bugzilla ticket doesn't. Need to consider duplicate reviews as well. We can't currently rename a repository; can we move repositories between namespaces?

  • Would really want the ability to click on a line in a source file and open an issue there, in the same manner as you can comment on a line in a patch in a PR. I know you can "fork and edit" and then send a PR, but that's not what's needed here, because the idea is to point out issues in a spec, not to have the reviewer do all of that fixing.

  • Hook up some form of CI so the package is rebuilt and rpmlint/fedora-review/whatnot are run as things change.

  • Do we need dependencies between repositories somehow? Would be useful in some sense, though one alternative would simply be to not open multiple reviews at once. The CI would show them as not building in any case.


As far as I know there is no progress on fresque, but I've seen this recently: https://fedorahosted.org/FedoraReview/ticket/277 (I should contact that person to ask them to get closer to the infra).

However, at this stage, I am not sure investigating this idea is a priority, it is food for thoughts though, definitely :)

I doubt it would be a priority for pagure, certainly, but it would be a priority if we ever did want to make any progress on making our review process not be so terrible. It seems that pagure has a large amount of functionality which could be leveraged here, even if whatever ends up happening doesn't live in the main pagure instance.

Some of the questions are still valid, though. Specifically, can we move repositories between namespaces? And is there any functionality for commenting on a particular portion of a file in a repository like there is with a patch in a pull requrest?

The last update was 6 years ago, no further requests, updates or actionable tasks since then, I'm going to close this issue for now to reduce our backlog.

Metadata Update from @wombelix:
- Issue close_status updated to: Won't Fix
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata