#1310 Wrong branches listed on pull request page
Closed: Fixed 7 years ago Opened 7 years ago by lsedlar.

Steps to reproduce:

  1. Go to https://pagure.io/pagure/pull-requests
  2. Click File Pull Request button
  3. See new_branch and branch_w_pr.

There are no such branches in my fork. This is not specific to this project, I can replicate it on other projects as well.


I can open the pull request perfectly fine from the home page of my fork, so this is not blocking anything.

There should be a POST ajax call made on that page to load these infos, could you check what it does/contain?

For Pagure:

{"code": "OK", "message": {"branch_w_pr": {}, "new_branch": {}}}

For Pungi where I have some branches (I removed list of commits, from the snippet, but they look correct to me):

{
  "code": "OK",
  "message": {
    "branch_w_pr": {
      "no-skip-checksum": 390,
      "test-linker": 385
    },
    "new_branch": {
      "3.x": […],
      "4.0.x": […],
      "add-docs": […]
    }
  }
}

Can you access the parameter sent? (not the cookie, the others)

Oh, I think I see the issue

The headers are:

POST /pv/pull-request/ready HTTP/1.1
Host: pagure.io
User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Accept: application/json, text/javascript, */*; q=0.01
Accept-Language: en-US,en;q=0.7,cs;q=0.3
Accept-Encoding: gzip, deflate, br
DNT: 1
Content-Type: application/x-www-form-urlencoded; charset=UTF-8
X-Requested-With: XMLHttpRequest
Referer: https://pagure.io/pungi/pull-requests
Content-Length: 114
Cookie: XXX
Connection: keep-alive

The request body is:

namespace=None&repo=pungi&repouser=lsedlar&csrf_token=XXX

It's good, now it shows correct branches that don't have a PR yet. Thank you.

@pingou changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata