#1216 PR comments don't show up until page is force-refreshed
Closed: Fixed 7 years ago Opened 7 years ago by sgallagh.

I added a comment on a pull-request (using Google Chrome 52) and it did not show up, even when I hit refresh on the page. It wasn't until I did a shift-refresh (a refresh forcing the cache to be discarded) that the comment appeared.


Generally, you don't need a refresh because we do have SSE server for this task. But, there is a known problem #462 . I don't know why it needed hard refresh though because, the issue is updated in the database and should have been available when refreshed.

There is problem with SSE server it has to be restarted once in a while. @pingou can give you more on this.

I run into this pretty regularly myself (on pagure.io)

Also issues, as the above comment did not load. How meta.

i thought this may be a configuration issue on my instance but this seems to be the case on this instance also

curl -I with http:// gives "HTTP/1.0 200 OK" and returns immediately
curl -I with https:// just hangs forever with no output

the most curious symptom i noticed about it - while curl is hanging on the terminal and i create a issue comment the page does not reload - but if i reload manually i see the comment was posted

the log shows 2 errors:

ERROR [base_events:1053] Future/Task exception was never retrieved
pagure-stream-server.py[31458]: UnicodeDecodeError: 'ascii' codec can't decode byte 0xb2 in position 4: ordinal not in range(128)

I'm seeing this lately, presumably this 'SSE server' is down? https://pagure.io/pagure/issue/1507 is probably a dupe.

This is especially nasty if you like posting serial comments (like me!) because if you post a short comment, submit it, forget to refresh, then type a long comment, the long comment gets eaten - it doesn't show up on the issue, and Firefox doesn't have it in history.

Hmm, that time it worked fine. I wonder if this is more namespace fun? Does it fail in namespaced projects? I'm finding all kinds of quirks in namespaced projects lately.

Yeah, on a quick eyeball, there's a namespace problem here:

repo = pagure.lib.get_project(pagure.SESSION, repo, user=username)

if repo is None:
    raise PagureEvException("Project '%s' not found" % repo)

nothing there accounts for namespacing. Will file a new issue and look into fixing it.

Ok so the namespace issue with SSE has been fixed. We still run into #462 once in a while but we don't have a clear fix for this at the moment.
We had another issue around posting comments that were actually never sent to due CSRF expiring and the server not saying so, this has also been fixed.

Finally #462 is still open, but we track its status there, so I think we can close this one as fixed for now.

@pingou changed the status to Closed

7 years ago

Login to comment on this ticket.

Metadata