Learn more about these different git repos.
Other Git URLs
As far as I can tell PR 40 for Fedora-kickstarts didn't really get merged. The commit doesn't show up and the change is not reflected in the file that should have been changed. https://pagure.io/fedora-kickstarts/pull-request/40
I am seeing the commit https://pagure.io/fedora-kickstarts/c/e64013997649f14b6d9afaffd09a7eb37c98a3d9?branch=f24 which seems to contain the change proposed in the PR 40 but for some reasons the commit message is a little different. Maybe Dennis did something when merging it?
That isn't the same commit. The commit in question is a correction for the commit you found. I was a bit confused by that as well. The commit you saw changed 'compose' to 'mash' and the new one is dropping 'mash'.
Is it OK if I get the requested change in or do you need things left alone in order to figure out what happened? I wanted to do a spin-kickstarts update for Fedora 24 including that change amoung others.
No feel free to re-open the PR or submit a new one, but I'll ask @ausil to let me know if he sees more of these situations
We have seen a few issues in the last week in fedora-kickstarts
another related bug: https://pagure.io/pagure/issue/2119
https://pagure.io/fedora-kickstarts/pull-request/170 https://pagure.io/pungi-fedora/pull-request/156
they were both merged. but I had to manually commit and push the patches
https://pagure.io/fedora-kickstarts/pull-request/181 another one that failed to merge
https://pagure.io/fedora-kickstarts/pull-request/202
https://pagure.io/pungi-fedora/pull-request/205
https://pagure.io/fedora-kickstarts/pull-request/184
I reworked logging in https://pagure.io/pagure/pull-request/2244 and added quite a bit of logging around merging PR while at it. I hope this helps figuring things out in the next release
https://pagure.io/releng/pull-request/6742 another PR which is not merged.
mother f** - this caused me a lot of pain today:
https://pagure.io/fedora-kickstarts/pull-request/223
Looking at the logs I'm seeing a traceback which is fixed in git, but when looking at the code, I wonder how the PR gets closed with this error, so I still don't really know what's going on
In https://pagure.io/pagure/pull-request/2274 @puiterwijk refactor the locking mechanism in the hope that it will fix the issue seen here.
This is part of pagure 2.15 which just got deployed.
Let's monitoring this and see if it still occurs.
Thanks!
Still not working
https://pagure.io/fedora-release/pull-request/102#
Commit a5677e9 fixes this issue
Login to comment on this ticket.