#1073 Please show what branches a commit resides on in the commit information page
Closed: Fixed Opened by ankursinha.

I think it'll be most useful. This is how github does it, for example:

github-commit-show-branch.png


will be there in the next release

Awesome. Maybe add a tag for it if you have perms?

Will this be enough?: http://img.susepaste.org/26560884

this is what i was talking about.

BTW, i am just a kid, i don't have any kind of permission.

The branch in the URL looks OK - I'd have preferred it to be nice and visible with the commit info, but as long as it's somewhere I guess it works :)

Shouldn't it be branches, not branch. Commits can be in multiple branches, so you'd probably want to list at least all of the branches from the current fork. It might also make sense to list branches from the main repo. Branches from other forks, would probably be too much clutter and not very useful.

Shouldn't it be branches, not branch. Commits can be in multiple branches, so you'd probably want to list at least all of the branches from the current fork. It might also make sense to list branches from the main repo. Branches from other forks, would probably be too much clutter and not very useful.

+1 - Updated ticket summary.

@pingou are we going to list the branches?

Not sure if this is feasible with our pygit2

So the only way to do it would be to:

  • For each branch in the repo
  • Find the common ancestor between that branch and the default one
  • Iterate all the commits between that top of the branch and the common ancestor, if you find the targeted commit, it's in there, otherwise it's in the default branch.

Ok I've managed to do so and this is how it would look:

pagure_branch_commit.png

  • It's loaded async (via JS)
  • It's only present in the commit detail page (not in the list of commits)

How does that sound?

Looks awesome to me :clap:

This got merged in #1083 let's close :)

Metadata