#1067 RFE: is it possible to autocomplete/suggest usernames when typing with @...?
Closed: Fixed None Opened 5 years ago by ankursinha.

It'll be quite useful - would keep users from making spelling errors and save them from needing to remember people's usernames too?


similar to this would be #s for PRs/Issues.

Please don't make it so that adding comments won't work with javascript disabled.
I don't think doing this will work well for PR or issue numbers as they are pretty dense. Maybe those could have a tool tip or something with the summary line so that you can check you pointed to the one you meant. I have seen at least one off by one error where the issue pointed to was legit, but not the one the person intended.

Please don't make it so that adding comments won't work with javascript disabled.

I confused as to why you would think that this change would change anything as to whether JS is mandatory to comment on tickets/PRs

I don't think doing this will work well for PR or issue numbers as they are pretty dense

Well, this ticket is about autocompleting usernames, so we should be fine wrt this :)

Maybe those could have a tool tip or something with the summary line so that you can check you pointed to the one you meant

If you hover over a link to a ticket/PR you will see its title, for example #1067 :)

I was worried about adding javascript processing of input in a way that wouldn't allow it to work at all if javascript is not enabled.
In a similar vein I have been meaning to complain about the fork button since it is set up with an onclick call to a javascript submit button, so it doesn't work without javascript enabled. There may be some reason to do it that way instead of using a submit button, but it isn't obvious to me.
The preview button for comments also requires javascript.
Assuming that the tooltips work in the preview (which I'd check except I had javascript disabled when I started working on this comment), then I don't think there would be significant benefit to autocompleting issue or PR numbers. You wouldn't get good guesses much of the time and you would still want to double check that you linked to the issue you intended in the preview.

My comment about issue / PR autocompletion was in reference to the comment that suggested adding that as well as doing it for usernames. I do see benefit to doing it for usernames.

Well, I was at least partly wrong about the fork button. It does actually work when javascript is disabled. I was having trouble with it previously, but there must have been something else wrong. I knew I wasn't really ready to complain about that yet. Anyway, I just brought that up as part of explaing why I was concerned about needing javascript enabled to use pagure's features. It's off topic here, and someday I might open another issue when I am better prepared with what I would like to see improved.

I understand your desire for a pagure working w/o all the JS and I'm trying to be careful with this, some features though (such as the preview) are imho, not doable without JS, it would have to bring you to a new page were you could see your comment, then either go back to edit or submit, I think the pain is worst than the gain here.

This is addressed in #1085.

For tickets, we need to adjust PRs in the same way and we should be able to close this ticket then :)

Alright, this got fixed in #1091 so let's close this ticket :)

Thanks for picking this up @atelic

Login to comment on this ticket.

Metadata