From ef0ab2c22f8366d5f3c5f1562d5e94cda6e1e997 Mon Sep 17 00:00:00 2001 From: Clement Verna Date: May 26 2016 10:27:59 +0000 Subject: Add missing if statement in add_issue_assignee --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index 8b227cc..89c3a21 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -341,24 +341,25 @@ def add_issue_assignee(session, issue, assignee, user, ticketfolder, if notify: pagure.lib.notify.notify_assigned_issue(issue, None, user_obj) - if not issue.private: - pagure.lib.notify.log( - issue.project, - topic='issue.assigned.reset', - msg=dict( - issue=issue.to_json(public=True), - project=issue.project.to_json(public=True), - agent=user_obj.username, - ), - redis=REDIS, - ) - # Send notification for the event-source server - if REDIS: - REDIS.publish('pagure.%s' % issue.uid, json.dumps( - {'unassigned': '-'})) + if not issue.private: + pagure.lib.notify.log( + issue.project, + topic='issue.assigned.reset', + msg=dict( + issue=issue.to_json(public=True), + project=issue.project.to_json(public=True), + agent=user_obj.username, + ), + redis=REDIS, + ) + + # Send notification for the event-source server + if REDIS: + REDIS.publish('pagure.%s' % issue.uid, json.dumps( + {'unassigned': '-'})) - return 'Assignee reset' + return 'Assignee reset' elif assignee is None and issue.assignee is None: return @@ -371,9 +372,9 @@ def add_issue_assignee(session, issue, assignee, user, ticketfolder, session.flush() pagure.lib.git.update_git( issue, repo=issue.project, repofolder=ticketfolder) - - pagure.lib.notify.notify_assigned_issue( - issue, assignee_obj, user_obj) + if notify: + pagure.lib.notify.notify_assigned_issue( + issue, assignee_obj, user_obj) if not issue.private: pagure.lib.notify.log(