From a0e9f73d2059cc4924dcc9e8f8e6ab577e711692 Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk Date: Oct 08 2018 21:56:11 +0000 Subject: Never set readonly flag if a dynamic auth backend is in use Signed-off-by: Patrick Uiterwijk --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index fc39836..4fe5e16 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -54,6 +54,7 @@ from flask import url_for import pagure.exceptions import pagure.lib.git +import pagure.lib.git_auth import pagure.lib.login import pagure.lib.notify import pagure.lib.plugins @@ -5407,6 +5408,10 @@ def update_read_only_mode(session, repo, read_only=True): or read_only not in [True, False] ): return + helper = pagure.lib.git_auth.get_git_auth_helper() + if helper.is_dynamic and read_only: + # No need to set a readonly flag if a dynamic auth backend is in use + return if repo.read_only != read_only: repo.read_only = read_only session.add(repo)