From 7aa7c1f781f45abbb51cfa0b0a03d8f08c98999d Mon Sep 17 00:00:00 2001 From: Björn Persson Date: Sep 16 2020 10:14:10 +0000 Subject: Don't return CONTINUE from eom. Because eom is the last callback function called for an email message, returning CONTINUE effectively means ACCEPT. Returning ACCEPT explicitly makes the meaning clearer. --- diff --git a/pagure-milters/comment_email_milter.py b/pagure-milters/comment_email_milter.py index 86f177b..3ea0171 100644 --- a/pagure-milters/comment_email_milter.py +++ b/pagure-milters/comment_email_milter.py @@ -149,7 +149,7 @@ class PagureMilter(Milter.Base): self.log( "No valid recipient email found in To/Cc: %s" % email_address ) - return Milter.CONTINUE + return Milter.ACCEPT if msg["From"] and msg["From"] == _config.get("FROM_EMAIL"): self.log("Let's not process the email we send")