From 045c5cd839d83a5b706e3587c8c4fe9d95db06ea Mon Sep 17 00:00:00 2001
From: Karsten Hopp <karsten@redhat.com>
Date: Sep 12 2018 12:14:23 +0000
Subject: populate dropdown-menu when button is clicked, not upon page load


fixes #3599
every page related to a git repository has a pull-request button that
opens a dropdown-menu. This menu is populated when the page loads, even
when creating a PR might not be the intention of visiting that page.

Signed-off-by: Karsten Hopp <karsten@redhat.com>

---

diff --git a/pagure/templates/repo_master.html b/pagure/templates/repo_master.html
index 7b1bb2a..b8004a0 100644
--- a/pagure/templates/repo_master.html
+++ b/pagure/templates/repo_master.html
@@ -95,7 +95,7 @@
             <div class="btn-group">
               <a href="#" class="btn btn-outline-primary btn-sm dropdown-toggle"
                 data-toggle="dropdown"
-                aria-haspopup="true" aria-expanded="false">
+                aria-haspopup="true" aria-expanded="false" id="pr-button">
                 <i class="fa fa-arrow-circle-down fa-fw"></i> Open PR
               </a>
               <div class="dropdown-menu dropdown-menu-right" id="PR-dropdown">
@@ -412,99 +412,103 @@ window.addEventListener("load", function(event) {
 {% if g.authenticated and not g.repo_obj.is_empty %}
 
 {% if g.repo_committer %}
-$(function() {
-  $.ajax({
-    url: '{{ url_for("internal_ns.get_pull_request_ready_branch") }}' ,
-    type: 'POST',
-    data: {
-      repo: "{{ repo.name }}",
-      namespace: "{{ repo.namespace if repo.namespace }}",
-      repouser: "",
-      csrf_token: "{{ g.confirmationform.csrf_token.current_token }}",
-    },
-    dataType: 'json',
-    error: function(res) {
-       console.log(res);
-    },
-    success: function(res) {
-      if (res.code == 'OK'){
-        var first_item = true;
-        for (branch in res.message.new_branch){
-          if (first_item){
-            $("#PR-dropdown").prepend("<div class='dropdown-divider'></div>")
-            first_item = false;
+$("#pr-button").click(
+  function() {
+    $.ajax({
+      url: '{{ url_for("internal_ns.get_pull_request_ready_branch") }}' ,
+      type: 'POST',
+      data: {
+        repo: "{{ repo.name }}",
+        namespace: "{{ repo.namespace if repo.namespace }}",
+        repouser: "",
+        csrf_token: "{{ g.confirmationform.csrf_token.current_token }}",
+      },
+      dataType: 'json',
+      error: function(res) {
+         console.log(res);
+      },
+      success: function(res) {
+        if (res.code == 'OK'){
+          var first_item = true;
+          for (branch in res.message.new_branch){
+            if (first_item){
+              $("#PR-dropdown").prepend("<div class='dropdown-divider'></div>")
+              first_item = false;
+            }
+            var url = "{{ url_for(
+              'ui_ns.new_request_pull',
+              repo=repo.name,
+              username=repo.user.user if repo.is_fork else None,
+              namespace=repo.namespace,
+              branch_to='-',
+              branch_from='-') }}";
+            url = url.slice(0, -4) + res.message.new_branch[branch]['target_branch'] + '..' + branch;
+            html = '<a class="dropdown-item" href="' + url + '">'
+              + '<span class="badge badge-light badge-pill border border-secondary font-size-1">'
+                + ' <i class="fa fa-calendar-o fa-rotate-270 fa-fw"></i> '
+                + '{{ repo.name }}'
+              + '</span> '
+              + '<span class="badge badge-secondary border border-secondary badge-pill font-size-1">'
+                + '<span class="fa fa-random fa-fw"> </span> '
+                + branch
+              + '</span></a> ';
+            $("#PR-dropdown").prepend(html);
           }
-          var url = "{{ url_for(
-            'ui_ns.new_request_pull',
-            repo=repo.name,
-            username=repo.user.user if repo.is_fork else None,
-            namespace=repo.namespace,
-            branch_to='-',
-            branch_from='-') }}";
-          url = url.slice(0, -4) + res.message.new_branch[branch]['target_branch'] + '..' + branch;
-          html = '<a class="dropdown-item" href="' + url + '">'
-            + '<span class="badge badge-light badge-pill border border-secondary font-size-1">'
-              + ' <i class="fa fa-calendar-o fa-rotate-270 fa-fw"></i> '
-              + '{{ repo.name }}'
-            + '</span> '
-            + '<span class="badge badge-secondary border border-secondary badge-pill font-size-1">'
-              + '<span class="fa fa-random fa-fw"> </span> '
-              + branch
-            + '</span></a> ';
-          $("#PR-dropdown").prepend(html);
         }
       }
-    }
-  });
-});
+    });
+  }
+);
 {% endif %}
 
-$(function() {
-  $.ajax({
-    url: '{{ url_for("internal_ns.get_pull_request_ready_branch") }}' ,
-    type: 'POST',
-    data: {
-      namespace: "{{ repo.namespace if repo.namespace }}",
-      repo: "{{ repo.name }}",
-      repouser: "{{ g.fas_user.username }}",
-      csrf_token: "{{ g.confirmationform.csrf_token.current_token }}",
-    },
-    dataType: 'json',
-    error: function(res) {
-      $('#spinnergif').hide()
-      console.log(res);
-    },
-    success: function(res) {
-      $('#spinnergif').hide()
-      console.log("done");
-      if (res.code == 'OK'){
-        var first_item = true;
-        for (branch in res.message.new_branch){
-          if (first_item){
-            $("#PR-dropdown").prepend("<div class='dropdown-divider'></div>");
-            first_item = false;
+$("#pr-button").click(
+  function() {
+    $.ajax({
+      url: '{{ url_for("internal_ns.get_pull_request_ready_branch") }}' ,
+      type: 'POST',
+      data: {
+        namespace: "{{ repo.namespace if repo.namespace }}",
+        repo: "{{ repo.name }}",
+        repouser: "{{ g.fas_user.username }}",
+        csrf_token: "{{ g.confirmationform.csrf_token.current_token }}",
+      },
+      dataType: 'json',
+      error: function(res) {
+        $('#spinnergif').hide()
+        console.log(res);
+      },
+      success: function(res) {
+        $('#spinnergif').hide()
+        console.log("done");
+        if (res.code == 'OK'){
+          var first_item = true;
+          for (branch in res.message.new_branch){
+            if (first_item){
+              $("#PR-dropdown").prepend("<div class='dropdown-divider'></div>");
+              first_item = false;
+            }
+            var url = "{{ url_for(
+              'ui_ns.new_request_pull',
+              repo=repo.name,
+              username=g.fas_user.username,
+              namespace=repo.namespace,
+              branch_to='-',
+              branch_from='-') }}";
+            url = url.slice(0, -4) + res.message.new_branch[branch]['target_branch'] + '..' + branch;
+            html = '<a class="dropdown-item" \
+            href="' + url + '"><span class="badge badge-light badge-pill border border-secondary font-size-1">'
+            + '<i class="fa fa-code-fork fa-fw"></i>'
+            +'{{ g.fas_user.username }}/{{ repo.name }}</span> '
+            +'<span class="badge badge-secondary border border-secondary badge-pill font-size-1">'
+            +'<i class="fa fa-random"></i> '
+            + branch + '</span></a> ';
+            $("#PR-dropdown").prepend(html);
           }
-          var url = "{{ url_for(
-            'ui_ns.new_request_pull',
-            repo=repo.name,
-            username=g.fas_user.username,
-            namespace=repo.namespace,
-            branch_to='-',
-            branch_from='-') }}";
-          url = url.slice(0, -4) + res.message.new_branch[branch]['target_branch'] + '..' + branch;
-          html = '<a class="dropdown-item" \
-          href="' + url + '"><span class="badge badge-light badge-pill border border-secondary font-size-1">'
-          + '<i class="fa fa-code-fork fa-fw"></i>'
-          +'{{ g.fas_user.username }}/{{ repo.name }}</span> '
-          +'<span class="badge badge-secondary border border-secondary badge-pill font-size-1">'
-          +'<i class="fa fa-random"></i> '
-          + branch + '</span></a> ';
-          $("#PR-dropdown").prepend(html);
         }
       }
-    }
-  });
-});
+    })
+  }
+);
 
 {% endif %}
 </script>