#5 Couple of small fixes to the PR and Issue objects
Merged 4 months ago by abompard. Opened 3 years ago by pingou.

file modified
+8 -8
@@ -143,8 +143,8 @@ 

          "tags": {"type": "array", "items": {"type": "string"}},

          # "priorities": {"type": "object"},

          # "custom_keys": {

-         #    "type": "array",

-         #    "items": {"type": "array", "items": {"type": "string"}},

+         # "type": "array",

+         # "items": {"type": "array", "items": {"type": "string"}},

          # },

          "close_status": {"type": "array", "items": {"type": "string"}},

          "milestones": {"type": "object", "properties": {"type": MILESTONES}},
@@ -259,10 +259,10 @@ 

                  {"type": "string"},

              ]

          },

-         "custom_fields": {

-             "type": "array",

-             "items": {"type": "array", "items": {"type": "string"}},

-         },

+         # "custom_fields": {

+         # "type": "array",

+         # "items": {"type": "array", "items": {"type": "string"}},

+         # },

          "closed_by": {"oneOf": [{"type": "null"}, USER]},

          "related_prs": {

              "oneOf": [{"type": "null"}, {"type": "array", "items": RELATED_PR}]
@@ -286,7 +286,7 @@ 

          "assignee",

          # "priorities",

          "milestone",

-         "custom_fields",

+         # "custom_fields",

          "closed_by",

          "related_prs",

      ],
@@ -317,7 +317,7 @@ 

          "closed_by": {"oneOf": [{"type": "null"}, USER]},

          "initial_comment": {"oneOf": [{"type": "null"}, {"type": "string"}]},

          "cached_merge_status": {"type": "string"},

-         "threshold_reached": {"oneOf": [{"type": "null"}, {"type": "string"}]},

+         "threshold_reached": {"oneOf": [{"type": "null"}, {"type": "boolean"}]},

          "tags": {"type": "array", "items": {"type": "string"}},

      },

      "required": [

no initial comment

2 new commits added

  • Do not enforce a certain structure on the custom_fields
  • The threshold_reach field is either null or a boolean, not a string
3 years ago

this looks like a black formatting change included on https://pagure.io/pagure-messages/c/d586e247e2d4a22913670e97c52fd6e6961ab67b . I'm fine with it but you could want to split the commit?

:thumbsup: on my side

Please split the commit with the formatting stuff..

Merging so we can get on with it :-)

Pull-Request has been merged by abompard

4 months ago
Metadata