#80 Move pagure-importer to python3
Merged by cverna. Opened by cverna.
cverna/pagure-importer move_to_py3  into  master

Download 80.patch

Remove dependency to PagureRepo Class taken from the pagure code base and makes changes need to use python3

3 new commits added

  • Fixing the py3 configparser and some cleanup
  • Adding spec file for py3 rpm
  • Adding python3 configparser

1 new commit added

  • Updated get contributors to use the python api

i find if contributor not in contributors better. Your wish though. :)

space before =

since, we are here: is this fixing https://pagure.io/pagure-importer/issue/63 ?

rebased

looks like it :)

1 new commit added

  • Find the email address in the git commit and not the github commit

change of emails to email will need an adjustment here as well: https://pagure.io/fork/cverna/pagure-importer/blob/move_to_py3/f/pagure_importer/utils/init.py#_170

(also, just making sure that you remember: pagure is using emails - a list of emails for a user along with a default_email - emails[0] if not mentioned)

rebased

I revert back to emails then if pagure need a list of emails :) . Thanks for the reminder .

Fixes issue #78

I'm not sure that you want the spec in the upstream sources, since that'll make it harder to make sure the Fedora one is uptodate.

You shouldn't need this, as this should just not be in the upstream tarball.

The changelog version should have the release attached, like: 1.2.3-1

It might be good to be more specific with this, like %{python3_sitelib}/pgimport*

There should be a blank line between changelog entries.

I am guessing, this change is due to the pygit2 version?

No I have remove utils/repo.py. this file was taken from pagure code base but we only used the push method. Here we can just use the native push method from pygit2

Thanks for the review, I'll make the change u have suggested and remove the spec file from the PR.

1 new commit added

  • Remove Spec file form repo

We had it in pagure because pygit2 broke its API at this place back then, probably not such an issue for pagure-importer these days.

:thumbsup:

Pull-Request has been merged by cverna

Metadata