#79 Add support for github issue assignee
Merged by vivekanand1101. Opened by vivekanand1101.
assign  into  master

Download 79.patch

I have tested by importing issues of fedora-infra/mote here: https://stg.pagure.io/adfafdaf

(few issues are repeating, that's because of import failed a few times)

https://stg.pagure.io/adfafdaf/issue/74 is one with the assignee

1 new commit added

  • Change few function and file names, they were big unnecessarily

why do we need issue.assignee here ? if only use issue.assignee.login ?

We should use if assignee is not None notation. Same above for github_issue.assignee

https://www.python.org/dev/peps/pep-0008/#programming-recommendations

Would be nice to give the progress like on fedorahosted. Something like "issue 1/123 added to repo."

That's in case there is no assignee. It either returns None or a user object

6 new commits added

  • Use 'is not None' instead of anything resulting to True while checking against None
  • Change few function and file names, they were big unnecessarily
  • Tell the user when one issue is created locally
  • The user object of assignee should be json serializable
  • Add assignee support for github importer
  • small pep8 fixes

6 new commits added

  • Use 'is not None' instead of anything resulting to True while checking against None
  • Change few function and file names, they were big unnecessarily
  • Tell the user when one issue is created locally
  • The user object of assignee should be json serializable
  • Add assignee support for github importer
  • small pep8 fixes

:thumbsup:

Pull-Request has been merged by vivekanand1101

thank you @cverna

Metadata