#48 Some make up in our code
Merged by vivekanand1101. Opened by vivekanand1101.
makeup  into  master

Download 48.patch
no initial comment

Since, i have not tested, this is not up for review.

@cverna i have exams going on till 3rd so, if you can check after applying the patch that both the importer works, that would be great. You probably will have to apply this pr's patch. (I am not sure about that patch as well, but it should work).

This method is needed .

I know its not following pep8, but I personally prefer the first option, but it is up to you to decide :)

Nice one ;)

I think it is easier to understand when it is all on 1 line, but same as abo

same as above, up to you

I didn't search among the files or read the code carefully but, i did a search on github. Are you sure about this?

I had doubt about this, i will revert back the change.

will revert back the change

yeah it use here https://pagure.io/pagure-importer/blob/master/f/pagure_importer/utils/importer_trac.py#_59 for example

cool. A lesson for me: never rely on github code search :/

rebased

:thumbsup:

Pull-Request has been merged by vivekanand1101

Metadata