PR#136: Don't add contributor's name if email is not found - pagure-importer

pagure-importer

#136 Don't add contributor's name if email is not found

Opened 7 years ago by batman. Modified 7 years ago

batman/pagure-importer error into master

Don't add contributor's name if email is not found

Vivek Anand • 7 years ago

9392fc6

pagure_importer/utils/__init__.py

file modified

+7 -6

		`@@ -114,12 +114,13 @@`
		`project_commits = project.get_commits()`
		`contributors = []`
		`for commit in project_commits:`
		`- contributor = {'fullname': commit.author.name,`
		`- 'emails': commit.commit.author.email,`
		`- 'name': commit.author.login}`
		`- if contributor not in contributors:`
		`- contributors.append(contributor)`
		`- click.echo('contributor added: ' + contributor['name'])`
		`+ if commit.author is not None and commit.author.email is not None:`
cverna commented 7 years ago if you add a try except block around this code it should work. I think it is acceptable to ignore the exception here.
		`+ contributor = {'fullname': commit.author.name,`
		`+ 'emails': commit.commit.author.email,`
		`+ 'name': commit.author.login}`
		`+ if contributor not in contributors:`
		`+ contributors.append(contributor)`
		`+ click.echo('contributor added: ' + contributor['name'])`

		`with open('contributors.json', 'w') as f:`
		`f.write(json.dumps(contributors))`

batman commented 7 years ago

All we look for while going through the commits of a
project is the emails and if we don't find that. There
is no point of entering their name

cverna commented on line 6 of pagure_importer/utils/__init__.py 7 years ago

instead of having the continue you could test that commit.author or commit.author.email is not None

Edited 7 years ago by cverna

rebased

7 years ago

rebased

7 years ago

cverna commented on line 11 of pagure_importer/utils/__init__.py 7 years ago

I think commit.author.email fails with fedora-infra/bodhi. pygithub is throwing an exception.
To be safe we could add a try except block around these tests

rebased

7 years ago

cverna commented 7 years ago

did you try it on bodhi ?

vivekanand1101 commented 7 years ago