pagure-importer

Clone
Source Code
GIT

#108 don't accept empty values in custom field values for trac tickets
Merged 7 years ago by cverna. Opened 7 years ago by vivekanand1101.
empty_custom_value  into  master

file modified
+4 -2 
@@ -146,8 +146,10 @@ 
 

                  pagure_field = {}
 

                  pagure_field['name'] = field.get('name')
 

                  pagure_field['key_type'] = field.get('key_type')
 

-                 pagure_field['value'] = trac_ticket.get(pagure_field['name'])
 

-                 pagure_fields.append(pagure_field)
 

+                 pagure_field['value'] = trac_ticket.get(
 

+                                     pagure_field['name'], "").strip()
 

+                 if pagure_field['value']:
 

+                     pagure_fields.append(pagure_field)
 

          return pagure_fields
 

  

      def create_issue(self, ticket_id):

Fixes #107

Maybe the .strip() could be done here?

It's 81 char already :p

rebased
7 years ago

For reference, there's also https://pagure.io/pagure/pull-request/1797 that will fix it server-side.

Do we still need this ?

I'd still do it, better safe than sorry :)

so let's merge it :open_hands:

Pull-Request has been merged by cverna
7 years ago
Metadata
None
No Tags
Changes Summary 1
+4 -2
file changed
pagure_importer/utils/importer_trac.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.