#71 Cloned tickets directory is not cleaned on error
Closed: Fixed Opened by mkosek.

When I try to migrate a fedorahosted repo, I got an error:

$ pgimport fedorahosted https://fedorahosted.org/foobar --tags
Enter your FAS Username: mkosek
Password: 
#### Repo available ####
1 - foobar.git
Choose the import destination repo  [1]:  
ERROR: Error in response: {u'message': u'XML_RPC privileges are required to perform this operation', u'code': 403, u'name': u'JSONRPCError'}

When I fixed the permissions on fedorahosted and tried again, I got a traceback:

$ pgimport fedorahosted https://fedorahosted.org/foobar --tags
Enter your FAS Username: mkosek
Password: 
#### Repo available ####
1 - clone-foobar.git
2 - foobar.git
Choose the import destination repo  [1]: 2
Traceback (most recent call last):
  File "/home/mkosek/devel/pagure_importer/virtenv/bin/pgimport", line 11, in <module>
    sys.exit(app())
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/pagure_importer/commands/fedorahosted.py", line 31, in fedorahosted
    trac_importer.import_issues(repo_name=repo_name, repo_folder=REPO_PATH)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/pagure_importer/utils/importer_trac.py", line 62, in import_issues
    newpath, new_repo = clone_repo(repo_name, repo_folder)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/pagure_importer/utils/git.py", line 37, in clone_repo
    new_repo = pygit2.clone_repository(repopath, newpath)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/pygit2/__init__.py", line 255, in clone_repository
    check_error(err)
  File "/home/mkosek/devel/pagure_importer/virtenv/lib/python2.7/site-packages/pygit2/errors.py", line 49, in check_error
    raise ValueError(message)
ValueError: '/tmp/clone-foobar.git' exists and is not an empty directory

@cverna changed the status to Closed

fixed by #96

Metadata