pagure-importer

#109 validate command line arguments before prompting the user for input
Opened by bowlofeggs. Modified

Open
Close Issue

pagure-importer will prompt the user for input before validating the command line arguments:

 rbarlow  ⓔ  pagure-importer  ~  devel  pagure-importer  pgimport github fedora-infra/bodhi
Enter your Github Username: bowlofeggs
Password: 
Enter github project name like pypingou/pagure: fedora-infra/bodhi
Usage: pgimport github [OPTIONS]
Error: Got unexpected extra argument (fedora-infra/bodhi)

It would be nice if it reported the unexpected extra argument before prompting for input.

Username, password and poject are all arguments you can pass to the command line. If you don't the user is prompted.
you could use pgimport github --username bowlofeggs --password bowlofpassword --project fedora-infra/bodhi

@bowlofeggs as @cverna said we can: pgimport github --project <projectname> . And giving support to both pgimport github <projectname> and pgimport github --project <projectname> will result in both: confusion and a little ugly code. :/ . If you don't object, we can close this one, i guess.

It could still know that it doesn't have a usable set of parameters before prompting the user for information. Basically, it shouldn't have asked me for my credentials when it could have known that it was going to fail due to me using the arguments incorrectly. To be clearer, I expected this behavior instead:

$ pgimport github fedora-infra/bodhi
Usage: pgimport github [OPTIONS]
Error: Got unexpected extra argument (fedora-infra/bodhi)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.