PR#95: reset to repo owner, not to None - pagure-dist-git

Karsten Hopp • 4 years ago

91f9899

pagure_distgit/plugin.py

file modified

+2 -2

		`@@ -426,11 +426,11 @@`
		`if form.fedora_assignee.data:`
		`fedora_assignee = form.fedora_assignee.data.strip()`
		`else:`
		`- fedora_assignee = None`
		`+ fedora_assignee = repo.user.username`
		`if form.epel_assignee.data:`
		`epel_assignee = form.epel_assignee.data.strip()`
		`else:`
		`- epel_assignee = None`
		`+ epel_assignee = repo.user.username`
		`try:`
		`if repo.bzoverride:`
		`repo.bzoverride.fedora_assignee = fedora_assignee`

Fix 'NOT NULL constraint' error when pressing the 'Reset to defaults' button for the bz overrides

Set assignee to repo owner instead of setting the assignee to None

Signed-off-by: Karsten Hopp karsten@redhat.com

Where is the NOT NULL coming from?

We went a different route in https://pagure.io/pagure-dist-git/pull-request/100 by making it explicit that the fields can be null which I think solves this problem.

So I'm going to close this pull-request.

Thanks for your work though!