#168 Restrict pushing new branches that are in "unspecified blacklist" to the releng user group
Closed by dherrera. Opened by dherrera.
dherrera/pagure-dist-git restrict_push_reserved_branch  into  master

Download 168.patch

This PR is a proposal to fix releng#12457.

The problem is that package maintainers should create new EPEL10 branches through the package-request process, but currently users can push those branches directly through distgit. Since EPEL branch names are matched in the Unspecified Blacklist regex array, this PR would make it for them to be filtered when creating new branches with those names.

Wouldn't this change break the fedpkg request-branch --no-git-branch workflow? In that scenario we want to allow pushing to a branch that doesn't exist yet.

Wouldn't this change break the fedpkg request-branch --no-git-branch workflow? In that scenario we want to allow pushing to a branch that doesn't exist yet.

Yes, it would disable people from doing that :/

Even if this fixes the problem, it's way too overkill to disable that usecase for this purpse... I'll just close it for now.

Pull-Request has been closed by dherrera

Metadata