Every time a web browser loads a pull request on src.fpo, I receive a notification that Pagure merged a commit even though Pagure didn't merge a commit. For example, I just received these when someone visited this pull request:
src.fpo
12:11 <fedora-notif> pagure pushed to python-virtualenvwrapper (master). "Updated pull-request d9f8ded18b2a433c9af4b5e502ddaba6: [Do not merge] Fix up python2 removal commit" https://src.fedoraproject.org/rpms/python-virtualenvwrapper/c/172b77e4868a7e357e8d79fecf6f5779883f2c06?branch=master (triggered by 12:11 <fedora-notif> https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45874) 12:11 <fedora-notif> pagure pushed to python-virtualenvwrapper (master). "Updated pull-request d9f8ded18b2a433c9af4b5e502ddaba6: [Do not merge] Fix up python2 removal commit" https://src.fedoraproject.org/rpms/python-virtualenvwrapper/c/ea035e2bb88c66b92c7e5862cd86393569665934?branch=master (triggered by 12:11 <fedora-notif> https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45874) 12:11 <fedora-notif> pagure pushed to python-virtualenvwrapper (master). "Updated pull-request d9f8ded18b2a433c9af4b5e502ddaba6: [Do not merge] Fix up python2 removal commit" https://src.fedoraproject.org/rpms/python-virtualenvwrapper/c/742e659b360075a6c4a5e15d086b2b2dcfcf9172?branch=master (triggered by 12:11 <fedora-notif> https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45874) 12:16 <fedora-notif> pagure pushed to python-virtualenvwrapper (master). "Updated pull-request d9f8ded18b2a433c9af4b5e502ddaba6: [Do not merge] Fix up python2 removal commit" https://src.fedoraproject.org/rpms/python-virtualenvwrapper/c/26e446b732eeaeed17b722722566935ed38d1478?branch=master (triggered by 12:16 <fedora-notif> https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45874)
I can also generate these messages by visiting pull requests myself.
Note also that those URLs are all 404s because nothing was merged.
hm, I've tried to see the fedmsg message using: fedmsg-tail --really-pretty --no-validate --query=topic and opening that PR but I'm not seeing anything from dist-git.
fedmsg-tail --really-pretty --no-validate --query=topic
Do you still see these notifications? If you run fedmsg-tail, do you see these fedmsg messages?
PS: I think this should be an infra issue instead as this project tracks the customization we're doing to pagure for dist-git while this is either something in pagure itself, or in FMN possibly.
Looking at datagrepper and going back until 2018-12-11 11:58:34 UTC I see only one message mentioning "Fix up python2 removal" which is: https://apps.fedoraproject.org/datagrepper/id?id=2018-4a19283a-f7ec-43bf-a629-77cc61214406&is_raw=true&size=extra-large :(
2018-12-11 11:58:34 UTC
Ok, found the messages using: https://apps.fedoraproject.org/datagrepper/raw?user=pagure Full example: https://apps.fedoraproject.org/datagrepper/id?id=2018-756b2f89-25d1-43ac-8f83-e2c9e9599b89&is_raw=true&size=extra-large
Two issues with this: - this is not pagure's fedmsg hook, it's the default one from dist-git - this is not about the "main" git repo, but about the "requests" one
Now that this is identified, let's see what we can do :)
I think I've fixed the issue in: https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=ef61cb0d1164a3bdf258c07582c273a10143c267
I'm going to close this as fixed, but please let me know if you see this again :)
Metadata Update from @pingou: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Metadata Update from @bowlofeggs: - Issue status updated to: Open (was: Closed)
This happened again just now:
16:08 <fedora-notif> bowlofeggs opened pull request #4 on rpms/python-bleach: Update URL to the new home under the Mozilla org. https://src.fedoraproject.org/rpms/python-bleach/pull-request/4 (triggered by https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45875) 16:23 <fedora-notif> pagure pushed to python-bleach (master). "Update URL to the new home under the Mozilla org. (..more)" https://src.fedoraproject.org/rpms/python-bleach/c/c70c0138be84ac6f89cfa73e55041f1689186f26?branch=master (triggered by https://apps.fedoraproject.org/notifications/bowlofeggs.id.fedoraproject.org/irc/45874)
Ah false alarm, looks like someone just merged that PR.
Metadata Update from @bowlofeggs: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.