I think there is missing some introduction, that we have bcond functionality? And probably reference to "/usr/lib/rpm/macros", where the bcond are defined.

Also, it could be interesting if their usage is explained in relation to the modules, where macros can be specified in modulemd file, but I understand this might be beyond the scope of your initial PR.

@vondruch I am happy to see us either get that text added (it is beyond the scope of my knowledge :D) or to break this PR in half so someone else can do the bcond work.

@asamalik @ignatenkobrain @vondruch who has the knowledge to do the bcond docs?

See also https://pagure.io/packaging-committee/issue/789

See also https://rpm.org/user_doc/conditional_builds.html

@churchyard are you suggesting we drop the bcond explanation or use it in support of furthering it and ask .. well you ... to augment what is here based on #789?

I'm not asking anything, I haven't yet read the PR, I'm just throwing (hopefully) relevant links at you :D

IIRC one fo the problems of #789 was that we would need to explain bconds, so I think we can use this to support #789 (but I am not sure yet).

I personally find this PR very helpful.

Not sure if I have knowledge deep enough to extend this further, nor to determine what else should be added, but I find it very useful in this form already.