1 new commit added
typo
Hello. Thanks for your contribution. I am very opinionated when it comes to Python spec files, so I'll share some inline feedback.
The guidelines do not promote the approach of setting a global %srcname or %pypi_name. The authors of the Python guidelines have an opinion that it makes spec files harder to read, especially given there are 3+ different "names" of Python packages. It is not forbidden, but it is not encouraged either. Please do no add this to the spec file.
Mixing the forge macros into the Python example/template makes the template unnecessarily complex. Packagers who like to use the forge macros are likely familiar with them and do not need a reminder here. Packagers who do not use them would only be confused by their presence here.
Using %autrorelease is absolutely fine. It is the preferred way nowadays anyway. Please, also update the example specfile (Pello) for consistency.
The rest of the changes are dependent -- no to srcname and forge, yes to autochangelog.
Ah i see. The reason for the srcname and forge is to make a usable spec file with minimal editing required
I would certainly not use the forge macros in an example spec (unless it's an example for the forge macros). Things like %srcname aren't beneficial in an example. It's not a template; its existence is to show how things work without anything unnecessary.
A recent example why srcname is a bad idea: https://src.fedoraproject.org/rpms/python-scikit-learn/c/0582b6a62d0bb856d5c4b71283d9191e6f0b8309?branch=rawhide
The reason for the srcname and forge is to make a usable spec file with minimal editing required
But the spec file is still riddled with ...s. There still needs to be editing.
Yeah, I don't think any of the changes in the PR (other than using %autorelease / %autochangelog) make sense. While rpmautospec is the default for packages now, the %forge macros are not, and they would just confuse things here.
Pull-Request has been closed by solomoncyj
@solomoncyj Would you like to send a PR with the %autorelease change?
I am travelling atm. Will do it once i get back. But autorelease os the norm now and users should already know, dont they