packaging-committee

#1394 Fix description of %{?systemd_requires} macro to match reality
Merged by ngompa. Opened by mschorm.
Unknown source master

Download 1394.patch

Fedora Rawhide, 40:

dnf install systemd-rpm-macros

rpm --eval %{?systemd_requires}

| Requires(post): systemd
| Requires(preun): systemd
| Requires(postun): systemd

I discovered this issue when processing 'fedora-review' tool output.
It reported:
| - systemd_post is invoked in %post, systemd_preun in %preun, and
| systemd_postun in %postun for Systemd service files.
| Note: Systemd service file(s) in maxscale
| See: https://docs.fedoraproject.org/en-US/packaging-
| guidelines/Scriptlets/#_scriptlets

And I remembered there is a macro for that, but the macro description in the docs
did not match the requirement stated by 'fedora-review'.

:thumbsup:

Pull-Request has been merged by ngompa

I'm looking at the next line, which says:

 Note that those dependencies are **not** required for the
  `%systemd_{post,preun,postun_with_restart,user_post,user_preun}`

I guess we should replace the post with pre there too.
What do you think @ngompa ?
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.