PR#1166: Change guidance on explicit build deps to account for generators - packaging-committee

packaging-committee

#1166 Change guidance on explicit build deps to account for generators

Merged 2 years ago by tibbs. Opened 2 years ago by carlwgeorge.

carlwgeorge/packaging-committee automatic-build-deps into master

Change guidance on explicit build deps to account for generators

Carl George • 2 years ago

35d21a3

guidelines/modules/ROOT/pages/index.adoc

file modified

+4 -2

		`@@ -752,8 +752,10 @@`
		`Automatically determined dependencies MUST NOT be duplicated`
		`by manual dependencies.`

		`- Build dependencies, however,`
		`- cannot be automatically determined and MUST be explicitly listed.`
		`+ Build dependencies, however, MUST be explicitly listed,`
		`+ unless you are using an automatic build dependency generator`
		`+ (e.g. xref:Rust.adoc#_buildrequires[Rust] or`
		`+ xref:Python.adoc#_build_time_dependency_generator[Python]).`
		`Refer to the <<buildrequires>>.`

		`Versioned dependencies (build-time or runtime) SHOULD ONLY be used`

no initial comment

tibbs commented 2 years ago

Yes, the old text is out of touch with reality, and I think it should be merged.

However, while hovering over the button... I do wonder if it still needs to be said that you must still list any build dependencies which aren't automatically generated. I kind of hope not but someone might read it that way. Would it be simpler to just say the following?