PR#1103: Fixes the dead hyper links to rpm.org - packaging-committee

packaging-committee

#1103 Fixes the dead hyper links to rpm.org

Merged 2 years ago by tibbs. Opened 2 years ago by hiwkby.

hiwkby/packaging-committee master into master

Fixes the wrong link

Hirotaka Wakabayashi • 2 years ago

d8ca618

Fixes the wrong hyper links

Hirotaka Wakabayashi • 2 years ago

c4943d6

guidelines/modules/ROOT/pages/AutoProvidesAndRequiresFiltering.adoc

file modified

+1 -1

		`@@ -155,4 +155,4 @@`

		`== Additional Information`

		`- Additional information about RPM's dependency generator can be found here: http://rpm.org/user_doc/dependency_generators.html`
		`+ Additional information about RPM's dependency generator can be found here: https://rpm-software-management.github.io/rpm/manual/dependency_generators.html`

guidelines/modules/ROOT/pages/Python.adoc

file modified

+2 -2

		`@@ -649,7 +649,7 @@`
		`The automatically generated requirements`
		are in the form `+python3.Xdist(DISTNAME)+`,
		`potentially augmented with version requirements or combined together`
		`- with https://rpm.org/user_doc/boolean_dependencies.html[rich dependencies].`
		`+ with https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html[rich dependencies].`
		Any `+.0+` suffixes are removed from version numbers
		`to match the behavior of Python tools.`
		`(https://www.python.org/dev/peps/pep-0440/[PEP 440] specifies`
		`@@ -997,7 +997,7 @@`

		`As an exception,`
		you MAY disable tests with an appropriate `+%if+` conditional
		`- (e.g. http://rpm.org/user_doc/conditional_builds.html[bcond])`
		`+ (e.g. https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html[bcond])`
		`when xref:index.adoc#bootstrapping[bootstrapping].`

		`Most errors in Python happen at run-time,`

guidelines/modules/ROOT/pages/Scriptlets.adoc

file modified

+3 -3

		`@@ -9,11 +9,11 @@`
		`This page offers a quick overview of RPM scriptlets`
		`and a number of common recipes for scriptlets in packages.`
		`For a more complete treatment of scriptlets,`
		`- please see the http://www.rpm.org/max-rpm-snapshot/[Maximum RPM book].`
		`+ please see the https://ftp.osuosl.org/pub/rpm/max-rpm/[Maximum RPM book].`

		`The version of RPM in Fedora also has functionality`
		`to automatically run scripts when files are placed in certain locations.`
		`- (See http://rpm.org/user_doc/file_triggers.html[1].)`
		`+ (See https://rpm-software-management.github.io/rpm/manual/file_triggers.html[1].)`
		`This potentially obviates the need for most of the scriptlets on this page,`
		`but is not currently implemented in all cases where it could be.`

		`@@ -120,7 +120,7 @@`
		`[#pretrans]`
		`=== The %pretrans Scriptlet`

		- Note that the `+%pretrans+` scriptlet will, in the particular case of system installation, run before anything at all has been installed. This implies that it cannot have any dependencies at all. For this reason, `+%pretrans+` is best avoided, but if used it MUST (by necessity) be written in Lua. See http://rpm.org/user_doc/lua.html for more information.
		+ Note that the `+%pretrans+` scriptlet will, in the particular case of system installation, run before anything at all has been installed. This implies that it cannot have any dependencies at all. For this reason, `+%pretrans+` is best avoided, but if used it MUST (by necessity) be written in Lua. See https://rpm-software-management.github.io/rpm/manual/lua.html for more information.

		`== Writing Scriptlets`

guidelines/modules/ROOT/pages/index.adoc

file modified

+1 -1

		`@@ -1181,7 +1181,7 @@`

		=== `+%autosetup+`

		- As an alternative to the usual `+%setup+` macro, the `+%autosetup+` can be used. In addition to the normal %setup tasks, it will apply all defined Patch# items in the spec automatically. It is also capable of handling VCS formatted patch files, but this will require additional BuildRequires, and assumes that _all_ patch files in the spec are formatted for that single VCS type. For this reason, it is not recommended that you specify a VCS with `+%autosetup+`. For more details on proper use of `+%autosetup+`, refer to the http://rpm.org/user_doc/autosetup.html[RPM documentation].
		+ As an alternative to the usual `+%setup+` macro, the `+%autosetup+` can be used. In addition to the normal %setup tasks, it will apply all defined Patch# items in the spec automatically. It is also capable of handling VCS formatted patch files, but this will require additional BuildRequires, and assumes that _all_ patch files in the spec are formatted for that single VCS type. For this reason, it is not recommended that you specify a VCS with `+%autosetup+`. For more details on proper use of `+%autosetup+`, refer to the https://rpm-software-management.github.io/rpm/manual/autosetup.html[RPM documentation].

		`=== Using %\{buildroot} and %\{optflags} vs $RPM_BUILD_ROOT and $RPM_OPT_FLAGS`

hiwkby commented 2 years ago

Hello, this PR fixes the dead links to rpm.org.

I don't know the right links well but I believe rpm-software-management.github.io might be the correct domain.
The "Maximum RPM book" page currently redirects to https://ftp.osuosl.org/pub/rpm/max-rpm.

tibbs commented 2 years ago

Thanks; I went through and tested all of the new links and they work properly. So I'm just going to go ahead and merge this since it certainly improves the situation.

However, I do wonder if it wouldn't be better to just stop linking to Maximum RPM. According to the copyright date it's been 21 years since it was updated, so while I'm sure some of it still supplies, it figures that it must be missing plenty.

I'll open a separate PR for that.